Add a full cluster restart test for index shrinking #25720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
>test
Closed
18 tasks
nik9000
approved these changes
Jul 18, 2017
Member
There was a problem hiding this comment.
I'd name the shrunken index index + "_shrunk" or something. I like that the indices are all named after the test that uses them.
Member
There was a problem hiding this comment.
I might do assertThat(totalShards, greaterThan(1));.
martijnvg
force-pushed
the
shrink_full_cluster_restart_test
branch
from
ef12ef3 to
ff7c749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #24939