[Tests] Add tests for SuggestionBuilder#build method #25549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
review
>test
cbuescher
force-pushed
the
addTests-SuggestionBuilderContext
branch
from
02cacce to
3148153
Compare
This change adds a basic unit test for the SuggestionSearchContext that is created as output of SuggestionBuilder#build. The current test only adds checks for the common fields (like text, prefix, fieldName etc...). Individual checks for each SuggestionBuilder subtype will be added in follow-up PRs. Relates to elastic#17118
cbuescher
force-pushed
the
addTests-SuggestionBuilderContext
branch
from
3148153 to
9325126
Compare
This was referenced Jul 6, 2017
nik9000
approved these changes
Jul 6, 2017
Member
Author
|
@nik9000 thanks a lot for the review, much appreciated |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jul 6, 2017
* master: Fix cluster health wait conditions in rolling restart tests Add cluster name validation to RemoteClusterConnection (elastic#25568) Removes deprecated usage of the FieldStats API in a test that verifies sequence number data in Lucene commit points. Instead, the test retrieves the _seq_no value from the commit point directly and converts it to a Long value. [Tests] Check output of SuggestionBuilder#build method (elastic#25549) [Docs] Document Bulk Processor for Java High Level REST Client (elastic#25572) Update REST client deps license and notice files (elastic#25573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a basic unit test for the SuggestionSearchContext that is
created as output of SuggestionBuilder#build. The current test only adds checks
for the common fields (like text, prefix, fieldName etc...). Individual checks
for each SuggestionBuilder subtype will be added in follow-up PRs.
Relates to #17118