Skip to content

Fix the documentation to state that the _id field is indexed. #25540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2017
Merged

Fix the documentation to state that the _id field is indexed. #25540

merged 1 commit into from
Jul 5, 2017

Conversation

@jpountz
Copy link
Contributor

@jpountz jpountz commented Jul 4, 2017

I forgot to update that part of the docs in #24460.

@jpountz jpountz added the >docs General docs changes label Jul 4, 2017
@jpountz jpountz requested a review from clintongormley July 4, 2017 16:30
clintongormley
clintongormley reviewed Jul 4, 2017
View reviewed changes
Copy link
Contributor

@clintongormley clintongormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of typos otherwise LGTM

docs/reference/mapping/fields/id-field.asciidoc Outdated
Copy link
Contributor

@clintongormley clintongormley Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a -> an

Copy link
Contributor

@clintongormley clintongormley Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete "index"

Copy link
Contributor

@clintongormley clintongormley Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and is -> which is

@jpountz jpountz merged commit 26de905 into elastic:master Jul 5, 2017
@jpountz jpountz added the v6.0.0 label Jul 5, 2017
@jpountz jpountz deleted the docs/id_field branch July 5, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clintongormley clintongormley clintongormley left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes v6.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpountz @clintongormley @colings86