Remove deprecated IdsQueryBuilder ctor #25529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor using `types` has been deprecated for a while now (starting with ES 5.1.). It can be removed in the next mayor version. Since types are optional they should be added with the #types() setter.
javanna
approved these changes
Jul 4, 2017
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM shall we mark this breaking-java?
Member
Author
I wasn't sure, the ctor has been deprecated in 5. |
cbuescher
added
>breaking-java
:Core/Infra/Transport API
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jul 4, 2017
* master: [Analysis] Support normalizer in request param (elastic#24767) Remove deprecated IdsQueryBuilder constructor (elastic#25529) Adds check for negative search request size (elastic#25397) test: also inspect the upgrade api response to check whether the upgrade really ran [DOCS] restructure java clients docs pages (elastic#25517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor using
typeshas been deprecated for a while now (starting withES 5.1.). It can be removed in the next mayor version. Since types are optional
they should be added with the #types() setter.