Add concurrent deprecation logger test #25481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since deprecation logging involves concurrency, this commit adds a test that the concurrency here is handled safely.
jasontedor
added
:Core/Infra/Logging
jasontedor
force-pushed
the
concurrent-deprecation-logger-test
branch
from
1c15a62 to
9eaaf1a
Compare
jaymode
approved these changes
Jun 29, 2017
Member
jaymode
left a comment
jaymode
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding the test!
jasontedor
added a commit
that referenced
this pull request
Jun 29, 2017
Since deprecation logging involves concurrency, this commit adds a test that the concurrency here is handled safely. Relates #25481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deprecation logging involves concurrency, this commit adds a test that the concurrency here is handled safely.
Relates #25474, relates #25457