Do not search locally if remote index pattern resolves to no indices #25436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how we determine if there were any remote indices that a search should have been executed against. Previously, we used the list of remote shard iterators but if the remote index pattern resolved to no indices there would be no remote shard iterators even though the request specified remote indices. The map of remote cluster names to the original indices is used instead so that we can determine if there were remote indices even when there are no remote shard iterators. Closes elastic#25426
jaymode
added
:Search/Search
javanna
approved these changes
Jun 28, 2017
jaymode
added a commit
that referenced
this pull request
Jun 28, 2017
…25436) This commit changes how we determine if there were any remote indices that a search should have been executed against. Previously, we used the list of remote shard iterators but if the remote index pattern resolved to no indices there would be no remote shard iterators even though the request specified remote indices. The map of remote cluster names to the original indices is used instead so that we can determine if there were remote indices even when there are no remote shard iterators. Closes #25426
jaymode
added a commit
that referenced
this pull request
Jun 28, 2017
…25436) This commit changes how we determine if there were any remote indices that a search should have been executed against. Previously, we used the list of remote shard iterators but if the remote index pattern resolved to no indices there would be no remote shard iterators even though the request specified remote indices. The map of remote cluster names to the original indices is used instead so that we can determine if there were remote indices even when there are no remote shard iterators. Closes #25426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how we determine if there were any remote indices that a search should have
been executed against. Previously, we used the list of remote shard iterators but if the remote
index pattern resolved to no indices there would be no remote shard iterators even though the
request specified remote indices. The map of remote cluster names to the original indices is used
instead so that we can determine if there were remote indices even when there are no remote shard
iterators.
Closes #25426