Port the remaining old indices search tests to full cluster restart qa module #25275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
>test
nik9000
approved these changes
Jun 16, 2017
Member
There was a problem hiding this comment.
I think it is ok to use the Version from Version.java.
Member
There was a problem hiding this comment.
I think I'd pull this to its own test case so it doesn't get confused with the other search tests. We assert with a search but I think this is more about the alias than search in general. I dunno why I feel this way. What do you think?
Member
Author
There was a problem hiding this comment.
Agreed, I'll move it to its own test.
…tart qa module Also tweaked the qa module's gradle file to actually run bwc tests against all index compat versions. Relates to elastic#24939
martijnvg
force-pushed
the
port_more_bwc_tests_2
branch
from
b245972 to
bcaa413
Compare
Closed
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweaked the qa module's gradle file to actually run bwc tests against all index compat versions when executing
gradle bwcTest.Relates to #24939