Higlighters: Fix MultiPhrasePrefixQuery rewriting #25103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unified highlighter rewrites MultiPhrasePrefixQuery to SpanNearQuer even when there is a single term in the phrase. Though SpanNearQuery throws an exception when the number of clauses is less than 2. This change returns a simple PrefixQuery when there is a single term and builds the SpanNearQuery otherwise. Relates elastic#25088
jimczi
added
:Search Relevance/Highlighting
nik9000
approved these changes
Jun 7, 2017
Contributor
Author
|
Thanks @nik9000 ! |
jimczi
added a commit
that referenced
this pull request
Jun 7, 2017
The unified highlighter rewrites MultiPhrasePrefixQuery to SpanNearQuer even when there is a single term in the phrase. Though SpanNearQuery throws an exception when the number of clauses is less than 2. This change returns a simple PrefixQuery when there is a single term and builds the SpanNearQuery otherwise. Relates #25088
jimczi
added a commit
that referenced
this pull request
Jun 7, 2017
The unified highlighter rewrites MultiPhrasePrefixQuery to SpanNearQuer even when there is a single term in the phrase. Though SpanNearQuery throws an exception when the number of clauses is less than 2. This change returns a simple PrefixQuery when there is a single term and builds the SpanNearQuery otherwise. Relates #25088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unified highlighter rewrites MultiPhrasePrefixQuery to SpanNearQuer even when there is a single term in the phrase.
Though SpanNearQuery throws an exception when the number of clauses is less than 2.
This change returns a simple PrefixQuery when there is a single term and builds the SpanNearQuery otherwise.
Relates #25088