Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 1, 2017

The error message was confusing because it doesn't include unreleased versions like CURRENT.

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nik9000.

@nik9000
Copy link
Member Author

nik9000 commented Jun 1, 2017

LGTM. Thanks @nik9000.

It was my fault in the first place!

@nik9000 nik9000 merged commit 6a167a7 into elastic:master Jun 1, 2017
nik9000 added a commit that referenced this pull request Jun 1, 2017
The error message was confusing because it doesn't
include unreleased versions like CURRENT.
@jasontedor
Copy link
Member

It was my fault in the first place!

To be fair, it's not apparent until you're confronted with the error message in a real situation that it's confusing. I had to resort to reading build.gradle to understand what was going on.

nik9000 added a commit that referenced this pull request Jun 1, 2017
The error message was confusing because it doesn't
include unreleased versions like CURRENT.
jasontedor added a commit to s12v/elasticsearch that referenced this pull request Jun 2, 2017
* master: (62 commits)
  Handle already closed while filling gaps
  [DOCS] Clarify behaviour of scripted-metric arg with empty parent buckets
  [DOCS] Clarify connections and gateway nodes selection in cross cluster search docs (elastic#24859)
  Java api: Remove unneeded getTookInMillis method (elastic#23923)
  Adds nodes usage API to monitor usages of actions (elastic#24169)
  Add superset size to Significant Term REST response (elastic#24865)
  Disallow multiple parent-join fields per mapping (elastic#25002)
  [Test] Remove unused test resources in core (elastic#25011)
  Scripting: Add optional context parameter to put stored script requests (elastic#25014)
  Extract a common base class for scroll executions (elastic#24979)
  Build: fix version sorting
  Build: Move verifyVersions to new branchConsistency task (elastic#25009)
  Add backwards compatibility indices
  Build: improve verifyVersions error message (elastic#25006)
  Add version 5.4.2 constant
  Docs: More search speed advices. (elastic#24802)
  Add version 5.3.3 constant
  Reorganize docs of global ordinals. (elastic#24982)
  Provide the TransportRequest during validation of a search context (elastic#24985)
  [TEST] fix SearchIT assertion to also accept took set to 0
  ...
@nik9000 nik9000 deleted the verify_versions_error_message branch June 7, 2017 14:51
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v5.4.2 v5.5.0 v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants