Stop using the mapping.single_type setting in percolator tests.
#24963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Search Relevance/Percolator
s1monw
approved these changes
May 30, 2017
Contributor
There was a problem hiding this comment.
can we use doc as the type?
Contributor
There was a problem hiding this comment.
I am curious, why is it less now?
Member
Author
There was a problem hiding this comment.
That is because with a single type, the _type indexed and stored fields are left out.
6 tasks
martijnvg
force-pushed
the
percolator_stop_using_single_type_setting
branch
2 times, most recently
from
e3680f1 to
a4782f5
Compare
martijnvg
force-pushed
the
percolator_stop_using_single_type_setting
branch
from
a4782f5 to
6945d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #24958