Port OldIndexBackwardsCompatibilityIT#assertBasicSearchWorks over to full cluster restart qa module #24954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
>test
nik9000
approved these changes
May 30, 2017
Member
There was a problem hiding this comment.
I don't think you need the Integer.toString bit.
Member
There was a problem hiding this comment.
Maybe Map<String, Object> toMap(Response response)?
Member
There was a problem hiding this comment.
Maybe testSearch instead?
I think it'd be nice to move some of the random document generation from testRandomDocumentsAndSnapshot below into this and just use testRandomDocumentsAndSnapshot for testing the translog stuff.
Member
There was a problem hiding this comment.
Maybe it should just be long instead of long_sort.
Closed
18 tasks
Member
Author
|
@nik9000 I've updated the PR, based on your feedback. |
nik9000
approved these changes
May 30, 2017
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Left a minor but otherwise LGTM.
Member
There was a problem hiding this comment.
We can allow flush here, I think.
martijnvg
force-pushed
the
move_OldIndexBackwardsCompatibilityIT_to_qa_module_part_1
branch
from
bca98cb to
0d1a487
Compare
…full cluster restart qa module. Relates to elastic#24939
martijnvg
force-pushed
the
move_OldIndexBackwardsCompatibilityIT_to_qa_module_part_1
branch
from
0d1a487 to
9531ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #24939