Add a dummy_index to upgrade tests to ensure we recover fine with replicas #24937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licas We default to 0 replicas in the rolling restart scenario already to ensure we test against worst case. Yet, this adds a dummy index to ensure we also recover and index with relicas just fine.
nik9000
approved these changes
May 29, 2017
Member
|
Maybe call it something like index_with_replicas? Test_index vs dummy_index is quite confusing. |
Member
|
Yeah. `index_without_replicas` more like.
…On Mon, May 29, 2017 at 10:22 AM Ryan Ernst ***@***.***> wrote:
Maybe call it something like index_with_replicas? Test_index vs
dummy_index is quite confusing.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#24937 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLosIxAQJz1f_D9pNTTATmWA3eOipnks5r-tS7gaJpZM4NpWIM>
.
|
Contributor
Author
|
done... |
s1monw
added a commit
that referenced
this pull request
May 29, 2017
…licas (#24937) We default to 0 replicas in the rolling restart scenario already to ensure we test against worst case. Yet, this adds a dummy index to ensure we also recover and index with replicas just fine.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 29, 2017
* master: Add a second refresh to concurrent relocation test Add a dummy_index to upgrade tests to ensure we recover fine with replicas (elastic#24937) Rework bwc snapshot projects to build up to two bwc versions (elastic#24870) Move the IndexDeletionPolicy to be engine internal (elastic#24930) [Tests] Harden InternalExtendedStatsTests (elastic#24934) TCorrecting api name (elastic#24924) Add search method to high level REST client (elastic#24796) Add fromXContent method to ClearScrollResponse (elastic#24909) ClearScrollRequest to implement ToXContentObject (elastic#24907) SearchScrollRequest to implement ToXContentObject (elastic#24906) Fix bug in weight computation for query cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We default to 0 replicas in the rolling restart scenario already to ensure
we test against worst case. Yet, this adds a dummy index to ensure we also
recover and index with replicas just fine.