Compute the took time of the query after the expand phase of field collapsing #24902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The took time computed for search requests does not take in account the expand search phase. This change delays the computation to after the expand phase finishes. Relates elastic#24900
jimczi
added
:Search/Search
s1monw
approved these changes
May 29, 2017
Contributor
s1monw
left a comment
s1monw
left a comment
There was a problem hiding this comment.
LGTM 2 but I wonder if we can test this somehow... not sure how... this one is tricky :)
jimczi
added a commit
that referenced
this pull request
May 31, 2017
The took time computed for search requests does not take in account the expand search phase. This change delays the computation to after the expand phase finishes. Relates #24900
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tooktime computed for search requests does not take in account the expand search phase.This change delays the computation to after the expand phase finishes.
Relates #24900