Move remaining pre-configured token filters into analysis-common #24716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin reimplements the one built into lucene's analysis jar so we don't depend on that in core. It'd probably be better to move the integration tests for fetching term vectors into analysis-common but that felt like a bigger change than was worth it.
The only thing it brings that the other tests don't is
We can integration test in analysis-common.
Member
Author
|
Thanks @rjernst! |
nik9000
added a commit
that referenced
this pull request
May 17, 2017
It was assuming that payloads were available in a context where they weren't. Relates to #24716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the remaining preconfigured token figured into the analysis-common module. There were a couple of tests in core that depended on the pre-configured token filters so I had to touch them:
GetTermVectorsCheckDocFreqITdepended ontype_as_payloadbut didn't do anything important with it. I dropped the dependency. Then I moved the test to a single node test case because we're trying to cut down on the number ofESIntegTestCasesubclasses.AbstractTermVectorsTestCaseand its subclasses depended ontype_as_payload. I dropped their usage of the token filter and added an integration test for the termvectors API that usestype_as_payloadto theanalysis-commonmodule.AnalysisModuleTestsexpected a few pre-configured token filtes be registered by default. They aren't any more so I dropped this assertion. We assert that theCommonAnalysisPluginregisters these pre-built token filters inCommonAnalysisFactoryTestsSearchQueryITandSuggestSearchIThad tests that depended on the specific behavior of the token filters so I moved the tests to integration tests inanalysis-common.