Add parsing method to GeoHashGrid aggregation #24589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
javanna
approved these changes
May 10, 2017
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
left a small comment, LGTM otherwise
Member
Author
There was a problem hiding this comment.
Not really, unless the key field was missing in the parsed XContent. I added the non null check just to avoid a NPE in this case.
Member
There was a problem hiding this comment.
if it can happen only due to a bug, I would not handle it then. Rather make sure that it is always set through tests or assertions? Or even leave the NPE.
tlrx
force-pushed
the
add-parsing-for-geohashgrid-agg
branch
from
207cf3f to
b9da59c
Compare
Member
Author
|
Thanks @javanna and @cbuescher ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the parsing logic for the InternalGeoHashGrid aggregation.