Validates updated settings on closed indices #24487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow non-dynamic settings to be updated on closed indices but we don't check if the updated settings can be used to open/create the index. This can lead to unrecoverable state where the settings are updated but the index cannot be reopened since the settings are not valid. Trying to update the invalid settings is also not possible since the update will fail to validate the current settings. This change adds the validation of the updated settings for closed indices and make sure that the new settings do not prevent the reopen of the index. Fixes #23787
jimczi
added
:Data Management/Indices APIs
jimczi
added a commit
that referenced
this pull request
May 11, 2017
We allow non-dynamic settings to be updated on closed indices but we don't check if the updated settings can be used to open/create the index. This can lead to unrecoverable state where the settings are updated but the index cannot be reopened since the settings are not valid. Trying to update the invalid settings is also not possible since the update will fail to validate the current settings. This change adds the validation of the updated settings for closed indices and make sure that the new settings do not prevent the reopen of the index. Fixes #23787
jimczi
added a commit
that referenced
this pull request
May 11, 2017
We allow non-dynamic settings to be updated on closed indices but we don't check if the updated settings can be used to open/create the index. This can lead to unrecoverable state where the settings are updated but the index cannot be reopened since the settings are not valid. Trying to update the invalid settings is also not possible since the update will fail to validate the current settings. This change adds the validation of the updated settings for closed indices and make sure that the new settings do not prevent the reopen of the index. Fixes #23787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow non-dynamic settings to be updated on closed indices but we don't
check if the updated settings can be used to open/create the index.
This can lead to unrecoverable state where the settings are updated but the index
cannot be reopened since the settings are not valid. Trying to update the invalid settings
is also not possible since the update will fail to validate the current settings.
This change adds the validation of the updated settings for closed indices and make sure that the new settings do not prevent the reopen of the index.
Fixes #23787