token_count type : add an option to count tokens (fix #23227) #24372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option "enable_position_increments" with default value true. If option is set to false, indexed value is the number of positions (position increments are not counted)
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
We don't backport new features to old branches so is there anything that prevents you to upgrade to 5.x ? |
Contributor
Author
|
Hi @jimczi, There's no "blocking" thing that prevents my company's project to upgrade to 5.x. |
Contributor
|
Ok thanks @fbaligand, I'll close this pull request then. New features should only be added to the latest branch otherwise people would never upgrade ;) |
Contributor
Author
|
that's not false :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option "enable_position_increments" with default value true.
If option is set to false, indexed value is the number of positions
(position increments are not counted)
This is a backport from PR #24175