Remove count() method from GeoCentroid aggregation interface #24366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
count()method from the GeoCentroid interface used for thegeo_centroidaggregation. It seems to be unused at least in our own codebase and we also don't write thecountvalue to the aggregation Rest response but only use it in the reduce method.This is the main reason for removing the method from the interface. When adding parsing for the aggregation responses for the
Highl level Rest Client we strive to provide all information available via the REST API to the user through the aggregation interface and it only makes sense to provide values through the interface that are also provided via REST.
The method could be deprecated in 5.x if necessary.