-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add parsing for InternalPercentilesBucket #24330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cbuescher
merged 1 commit into
elastic:feature/client_aggs_parsing
from
cbuescher:addParsing-InternalPercentilesBucket
Apr 27, 2017
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
...search/search/aggregations/pipeline/bucketmetrics/percentile/ParsedPercentilesBucket.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.search.aggregations.pipeline.bucketmetrics.percentile; | ||
|
|
||
| import org.elasticsearch.common.xcontent.ObjectParser; | ||
| import org.elasticsearch.common.xcontent.XContentBuilder; | ||
| import org.elasticsearch.common.xcontent.XContentParser; | ||
| import org.elasticsearch.search.aggregations.metrics.percentiles.ParsedPercentiles; | ||
| import org.elasticsearch.search.aggregations.metrics.percentiles.Percentiles; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Map.Entry; | ||
|
|
||
| public class ParsedPercentilesBucket extends ParsedPercentiles implements Percentiles { | ||
|
|
||
| @Override | ||
| public String getType() { | ||
| return PercentilesBucketPipelineAggregationBuilder.NAME; | ||
| } | ||
|
|
||
| @Override | ||
| public double percentile(double percent) throws IllegalArgumentException { | ||
| Double value = percentiles.get(percent); | ||
| if (value == null) { | ||
| throw new IllegalArgumentException("Percent requested [" + String.valueOf(percent) + "] was not" + | ||
| " one of the computed percentiles. Available keys are: " + percentiles.keySet()); | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| @Override | ||
| public String percentileAsString(double percent) { | ||
| double value = percentile(percent); // check availability as unformatted value | ||
| String valueAsString = percentilesAsString.get(percent); | ||
| if (valueAsString != null) { | ||
| return valueAsString; | ||
| } else { | ||
| return Double.toString(value); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public XContentBuilder doXContentBody(XContentBuilder builder, Params params) throws IOException { | ||
| builder.startObject("values"); | ||
| for (Entry<Double, Double> percent : percentiles.entrySet()) { | ||
| double value = percent.getValue(); | ||
| boolean hasValue = !(Double.isNaN(value)); | ||
| Double key = percent.getKey(); | ||
| builder.field(Double.toString(key), hasValue ? value : null); | ||
| String valueAsString = percentilesAsString.get(key); | ||
| if (hasValue && valueAsString != null) { | ||
| builder.field(key + "_as_string", valueAsString); | ||
| } | ||
| } | ||
| builder.endObject(); | ||
| return builder; | ||
| } | ||
|
|
||
| private static ObjectParser<ParsedPercentilesBucket, Void> PARSER = | ||
| new ObjectParser<>(ParsedPercentilesBucket.class.getSimpleName(), true, ParsedPercentilesBucket::new); | ||
|
|
||
| static { | ||
| ParsedPercentiles.declarePercentilesFields(PARSER); | ||
| } | ||
|
|
||
| public static ParsedPercentilesBucket fromXContent(XContentParser parser, String name) throws IOException { | ||
| ParsedPercentilesBucket aggregation = PARSER.parse(parser, null); | ||
| aggregation.setName(name); | ||
| return aggregation; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need an assertFromXContent method here? Maybe if not we should have it empty so it will be easier one day to make the base method abstract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I missed that and added one in the last commit.