Add parsing for InternalExtendedStats #24284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
force-pushed
the
addParsing-ExtendedStats
branch
from
ac57688 to
2a274dd
Compare
Member
Author
|
Rebased after merging #24239, this should be ready for review now. |
cbuescher
force-pushed
the
addParsing-ExtendedStats
branch
from
2a274dd to
c5989a3
Compare
javanna
approved these changes
Apr 25, 2017
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM besides the small comment I left
| commonStatsAssertions(aggregation, parsed); | ||
| } | ||
|
|
||
| static void commonStatsAssertions(InternalStats aggregation, ParsedStats parsed) { |
Member
There was a problem hiding this comment.
can you rename this method, I'd like method names to contain a verb which indicates what they do e.g. assertStats ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #24085 this adds parsing for InternalExtendedStats.
PR is against the current feature branch for aggregation parsing.
Relates to #24239.