Skip to content

Templates: Add compileTemplate method to ScriptService for template consumers #24280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2017
Merged

Templates: Add compileTemplate method to ScriptService for template consumers #24280

merged 3 commits into from
Apr 24, 2017

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Apr 24, 2017

This commit adds a compileTemplate method to the ScriptService.
Eventually this will be used to easily cutover all consumers to a new
TemplateService.

relates #16314

@rjernst
Templates: Add compileTemplate method to ScriptService for template c…
fe1d6e0 
…onsumers

This commit adds a compileTemplate method to the ScriptService.
Eventually this will be used to easily cutover all consumers to a new
TemplateService.

relates elastic#16314
@rjernst rjernst added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >non-issue v5.5.0 v6.0.0-alpha1 labels Apr 24, 2017
@rjernst rjernst requested review from jdconrad and nik9000 April 24, 2017 07:08
jdconrad
jdconrad approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @rjernst Thanks for getting this project rolling.

nik9000
nik9000 approved these changes Apr 24, 2017
View reviewed changes
core/src/main/java/org/elasticsearch/script/ScriptService.java Outdated
}
}

/** Compiles a template. Note this will be moved toa separate TemplateService in the future. */
Copy link
Member

@nik9000 nik9000 Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/toa /to a /

@rjernst rjernst merged commit 6ebf087 into elastic:master Apr 24, 2017
@rjernst rjernst deleted the template1 branch April 24, 2017 22:45
rjernst added a commit that referenced this pull request Apr 24, 2017
@rjernst
Templates: Add compileTemplate method to ScriptService for template c…
e7231f1 
…onsumers (#24280)

This commit adds a compileTemplate method to the ScriptService.
Eventually this will be used to easily cutover all consumers to a new
TemplateService.

relates #16314
@martijnvg martijnvg mentioned this pull request Apr 25, 2017
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

@jdconrad jdconrad jdconrad approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >non-issue v5.5.0 v6.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rjernst @nik9000 @jdconrad