[Test] Always check the XContent equivalent when parsing aggregations #24208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In InternalAggregationTestCase, we can check that the internal aggregation and the parsed aggregation always produce the same XContent even if the original internal aggregation has been shuffled or not.
tlrx
added
:Java High Level REST Client
>non-issue
>test
cbuescher
reviewed
Apr 20, 2017
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, left one minor comment
|
|
||
| final BytesReference parsedBytes = toXContent((ToXContent) parsedAggregation, xContentType, params, humanReadable); | ||
| assertToXContentEquivalent(originalBytes, parsedBytes, xContentType); | ||
| final Aggregation parsedAggregation = parseAndAssert(aggregation, xContentType, randomBoolean(), randomBoolean()); |
Member
There was a problem hiding this comment.
Nit: could this by simplified even more by randomizing the xContentType, humanReadable and shuffle flag inside of parsedAggregation? Not sure about other callers of this method...
Member
Author
There was a problem hiding this comment.
Sure, thanks for the suggestion
cbuescher
approved these changes
Apr 20, 2017
Member
Author
|
Thanks @cbuescher ! |
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2017
elastic#24208) In InternalAggregationTestCase, we can check that the internal aggregation and the parsed aggregation always produce the same XContent even if the original internal aggregation has been shuffled or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mixed up things in #24183 when adding the parse() method in
InternalAggregationTestCase.This pull request fixes
InternalAggregationTestCaseso that it always checks that the internal aggregation and the parsed aggregation always produce the same XContent (usingassertToXContentEquivalent()) even when the original internal aggregation has been shuffled.