Plugins: Remove leniency for missing plugins dir #24173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leniency was left in after plugin installer refactoring for 2.0 because some tests still relied on it. However, the need for this leniency no longer exists.
rjernst
added
:Core/Infra/Plugins
Contributor
|
LGTM |
jimczi
approved these changes
Apr 19, 2017
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 19, 2017
* master: Wait for cluster to become quiescent between REST tests (elastic#24148) Plugins: Remove leniency for missing plugins dir (elastic#24173) Changing some grammar in docs (elastic#24164)
Contributor
|
@rjernst is backport still pending? |
rjernst
added a commit
that referenced
this pull request
May 5, 2017
This leniency was left in after plugin installer refactoring for 2.0 because some tests still relied on it. However, the need for this leniency no longer exists.
Member
Author
|
Indeed, it was, I had forgotten. It is backported now. |
rjernst
added a commit
that referenced
this pull request
May 16, 2017
Member
Author
|
Upon further reflection, I'm not sure why I had this marked for backport in the first place. It is "technically" a breaking change, so I have reverted this from 5.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leniency was left in after plugin installer refactoring for 2.0
because some tests still relied on it. However, the need for this
leniency no longer exists.