Engine: version logic on replicas should not be hard coded #23998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring in elastic#23711 hardcoded version logic for replica to assume monotonic versions. Sadly that's wrong for `FORCE` and `VERSION_GTE`. Instead we should use the methods in VersionType to detect conflicts. Note - once replicas use sequence numbers for out of order delivery, this logic goes away.
jasontedor
reviewed
Apr 9, 2017
| version = i; | ||
| break; | ||
| case EXTERNAL_GTE: | ||
| version = randomBoolean() && i > 0 ? i - 1 : i; |
Member
There was a problem hiding this comment.
Is this clearer: version = randomBoolean() ? Math.max(i - 1, 0) : i;?
jasontedor
approved these changes
Apr 9, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. I left one comment. Is the title of the pull request/commit message correct?
bleskes
changed the title
Contributor
Author
No... it missed a |
bleskes
added a commit
that referenced
this pull request
Apr 10, 2017
The refactoring in #23711 hardcoded version logic for replica to assume monotonic versions. Sadly that's wrong for `FORCE` and `VERSION_GTE`. Instead we should use the methods in VersionType to detect conflicts.
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring in #23711 hardcoded version logic for replica to assume monotonic versions. Sadly that's wrong for
FORCEandVERSION_GTE. Instead we should use the methods in VersionType to detect conflicts.Note - once replicas use sequence numbers for out of order delivery, this logic goes away.