[API] change wait_for_completion default according to docs #23672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
approved these changes
Mar 21, 2017
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
If this one is wrong then update_by_query and delete_by_query might also be wrong.
honzakral
force-pushed
the
rest-api-spec-reindex
branch
from
8fb7548 to
bde37a3
Compare
Contributor
Author
|
good catch @nik9000, updated the commit to include those APIs |
Member
LGTM. Thanks for fixing my mistake. |
1 similar comment
Member
LGTM. Thanks for fixing my mistake. |
colings86
added
>bug
>test
honzakral
added a commit
that referenced
this pull request
Mar 22, 2017
honzakral
added a commit
that referenced
this pull request
Mar 22, 2017
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2017
* master: [API] change wait_for_completion defaults according to docs (elastic#23672) Share XContent rendering code in terms aggs (elastic#23680) Update ingest-node.asciidoc [DOCS] Update the docs about the fact that global ordinals for _parent field are loaded eagerly instead of lazily by default. Build: remove progress logger hack for gradle 2.13 (elastic#23679) Test: Add dump of integ test cluster logs on failure (elastic#23688) Plugins: Add plugin cli specific exit codes (elastic#23599) Plugins: Output better error message when existing plugin is incompatible (elastic#23562) Reindex: wait for cleanup before responding (elastic#23677) Packaging: Remove classpath ordering hack (elastic#23596) Docs: Add note about updating plugins requiring removal and reinstallation (elastic#23597) Build: Make plugin list for smoke tester dynamic (elastic#23601) [TEST] Propertly cleans up failing restore test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.elastic.co/guide/en/elasticsearch/reference/5.2/docs-reindex.html#_url_parameters_3 the default is indeed
true