Build: Upgrade min gradle to 3.3 #23544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to get rid of deprecation warnings that appear when using 3.3, and also get rid of extra logic for 2.13 required because of the progress logger.
Member
|
Lgtm. Fire when ready. |
Member
|
There is a reference to version 2.13 in the CONTRIBUTING.md, and a reference to version 2.13 in README.textile. I think those should be changed with this change. |
jasontedor
requested changes
Mar 13, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
There are a few places in the docs that should be updated with this.
Member
Author
|
@jasontedor @nik9000 I updated the readme and contributing docs. |
rjernst
added a commit
that referenced
this pull request
Mar 21, 2017
This will allow us to get rid of deprecation warnings that appear when using 3.3, and also get rid of extra logic for 2.13 required because of the progress logger.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2017
* master: Fix typo in allocation explain API docs Add unit tests for ReverseNestedAggregator (elastic#23651) Revert "Revert "Build: Upgrade min gradle to 3.3 (elastic#23544)"" Revert "Build: Upgrade min gradle to 3.3 (elastic#23544)" Build: Upgrade min gradle to 3.3 (elastic#23544) Fix took assertion in response filter test Search took time should use a relative clock Adds toString() to snapshot operations in progress Docs: fix a typo in transport client's put-mapping.asciidoc (elastic#23607) Use include-tagged macro for high level client docs (elastic#23438) Update fill-column in .dir-locals.el to 100 characters Setup keystore during integration tests (elastic#22966) Fix typo 'Elastisearch' -> 'Elasticsearch' (elastic#23633) Comment and blank line cleanups (elastic#23647) docs: guidelines for students and teachers (elastic#23648) Fix MapperService StackOverflowError (elastic#23605)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to get rid of deprecation warnings that appear when
using 3.3, and also get rid of extra logic for 2.13 required because of
the progress logger. This commit simply upgrades the minimum version to 3.3, and those other cleanups will be done as followups.