Skip to content

Conversation

@thefourtheye
Copy link
Contributor

The docs don't clearly explain that the deleted doc count also comes from lucene.
IMHO, it is worth highlighting this information separately, as a Note.
Apart from that, there should be an official recommended alternative as well.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?

The docs don't clearly explain that the deleted doc count also comes from lucene.
IMHO, it is worth highlighting this information separately, as a Note.
Apart from that, there should be an official recommended alternative as well.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thefourtheye
Copy link
Contributor Author

Bump!

1 similar comment
@thefourtheye
Copy link
Contributor Author

Bump!

@nik9000 nik9000 added the >docs General docs changes label Apr 18, 2017
@nik9000
Copy link
Member

nik9000 commented Apr 18, 2017

Sorry this sat for so long! The change makes sense to me and renders well. I'll merge and cherry-pick as appropriate.

@nik9000 nik9000 merged commit dd3bbfb into elastic:master Apr 18, 2017
nik9000 pushed a commit that referenced this pull request Apr 18, 2017
The docs don't clearly explain that the deleted doc count also comes from lucene.
IMHO, it is worth highlighting this information separately, as a Note.
Apart from that, there should be an official recommended alternative as well.
nik9000 pushed a commit that referenced this pull request Apr 18, 2017
The docs don't clearly explain that the deleted doc count also comes from lucene.
IMHO, it is worth highlighting this information separately, as a Note.
Apart from that, there should be an official recommended alternative as well.
nik9000 pushed a commit that referenced this pull request Apr 18, 2017
The docs don't clearly explain that the deleted doc count also comes from lucene.
IMHO, it is worth highlighting this information separately, as a Note.
Apart from that, there should be an official recommended alternative as well.
@nik9000
Copy link
Member

nik9000 commented Apr 18, 2017

Merged and cherry-picked to 5.3, 5.4, and 5.x branches. Thanks @thefourtheye!

@thefourtheye thefourtheye deleted the patch-1 branch April 18, 2017 01:54
@thefourtheye
Copy link
Contributor Author

Thanks @nik9000 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants