Skip to content

Update to Azure Storage 5.0.0 #23517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2017
Merged

Update to Azure Storage 5.0.0 #23517

merged 1 commit into from
Mar 30, 2017

Conversation

@dadoonet
Copy link
Contributor

@dadoonet dadoonet commented Mar 9, 2017

Closes #23448.

@dadoonet dadoonet self-assigned this Mar 9, 2017
This was referenced Mar 9, 2017
Merged
Closed
@dadoonet dadoonet requested a review from tlrx March 16, 2017 10:30
@dadoonet
Copy link
Contributor Author

dadoonet commented Mar 16, 2017

@tlrx Could you review it please?

@dadoonet
Copy link
Contributor Author

dadoonet commented Mar 30, 2017

I'm planning to merge this on Friday, March 31st, unless anyone objects.

@jasontedor
Copy link
Member

jasontedor commented Mar 30, 2017

I'm planning to merge this on friday, March 31st, unless anyone objects.

I object to this, this requires a review.

danielmitterdorfer
danielmitterdorfer approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dadoonet dadoonet removed the request for review from tlrx March 30, 2017 16:35
@dadoonet dadoonet removed the review label Mar 30, 2017
@dadoonet
Copy link
Contributor Author

dadoonet commented Mar 30, 2017

Thanks @danielmitterdorfer!

@dadoonet dadoonet merged commit 9bd3d7c into elastic:master Mar 30, 2017
@dadoonet dadoonet deleted the pr/23448-update-azure-storage branch March 30, 2017 16:46
dadoonet added a commit that referenced this pull request Mar 30, 2017
@dadoonet
Update to Azure Storage 5.0.0
12dd1b4 
Related to #23448
Backport of #23517 in 5.x branch (5.4)
@dadoonet
Copy link
Contributor Author

dadoonet commented Mar 30, 2017

Pushed in 5.x with 12dd1b4

dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Jun 2, 2017
@dadoonet
Support for accessing Azure repositories through a proxy
d38d1b2 
You can define a proxy using the following settings:

```yml
cloud:
    azure:
        storage:
            my_account:
                account: your_azure_storage_account
                key: your_azure_storage_key
                proxy:
                    host: proxy.host
                    port: 8888
                    type: http
```

Supported values for `proxy.type` are `direct`, `http` or `socks`. Defaults to `direct` (no proxy).

Note that this commit depends on elastic#23517 which needs to be merged first (upgrade azure client to 5.0.0).

Closes elastic#23506
@clintongormley clintongormley added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Repository Azure labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees

@dadoonet dadoonet

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >upgrade v5.4.0 v6.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dadoonet @jasontedor @danielmitterdorfer @clintongormley