-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Tests InternalSingleBucketAggregation subclasses #23388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
...org/elasticsearch/search/aggregations/bucket/InternalSingleBucketAggregationTestCase.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.search.aggregations.bucket; | ||
|
|
||
| import org.elasticsearch.search.DocValueFormat; | ||
| import org.elasticsearch.search.aggregations.InternalAggregation; | ||
| import org.elasticsearch.search.aggregations.InternalAggregationTestCase; | ||
| import org.elasticsearch.search.aggregations.InternalAggregations; | ||
| import org.elasticsearch.search.aggregations.metrics.max.InternalMax; | ||
| import org.elasticsearch.search.aggregations.metrics.min.InternalMin; | ||
| import org.elasticsearch.search.aggregations.pipeline.PipelineAggregator; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static java.util.Collections.emptyList; | ||
| import static java.util.Collections.emptyMap; | ||
|
|
||
| public abstract class InternalSingleBucketAggregationTestCase<T extends InternalSingleBucketAggregation> | ||
| extends InternalAggregationTestCase<T> { | ||
| private final boolean hasInternalMax = randomBoolean(); | ||
| private final boolean hasInternalMin = randomBoolean(); | ||
|
|
||
| protected abstract T createTestInstance(String name, long docCount, InternalAggregations aggregations, | ||
| List<PipelineAggregator> pipelineAggregators, Map<String, Object> metaData); | ||
| protected abstract void extraAssertReduced(T reduced, List<T> inputs); | ||
|
|
||
| @Override | ||
| protected final T createTestInstance(String name, List<PipelineAggregator> pipelineAggregators, Map<String, Object> metaData) { | ||
| List<InternalAggregation> internal = new ArrayList<>(); | ||
| if (hasInternalMax) { | ||
| internal.add(new InternalMax("max", randomDouble(), | ||
| randomFrom(DocValueFormat.BOOLEAN, DocValueFormat.GEOHASH, DocValueFormat.IP, DocValueFormat.RAW), emptyList(), | ||
| emptyMap())); | ||
| } | ||
| if (hasInternalMin) { | ||
| internal.add(new InternalMin("min", randomDouble(), | ||
| randomFrom(DocValueFormat.BOOLEAN, DocValueFormat.GEOHASH, DocValueFormat.IP, DocValueFormat.RAW), emptyList(), | ||
| emptyMap())); | ||
| } | ||
| // we shouldn't use the full long range here since we sum doc count on reduce, and don't want to overflow the long range there | ||
| long docCount = between(0, Integer.MAX_VALUE); | ||
| return createTestInstance(name, docCount, new InternalAggregations(internal), pipelineAggregators, metaData); | ||
| } | ||
|
|
||
| @Override | ||
| protected final void assertReduced(T reduced, List<T> inputs) { | ||
| assertEquals(inputs.stream().mapToLong(InternalSingleBucketAggregation::getDocCount).sum(), reduced.getDocCount()); | ||
| if (hasInternalMax) { | ||
| double expected = inputs.stream().mapToDouble(i -> { | ||
| InternalMax max = i.getAggregations().get("max"); | ||
| return max.getValue(); | ||
| }).max().getAsDouble(); | ||
| InternalMax reducedMax = reduced.getAggregations().get("max"); | ||
| assertEquals(expected, reducedMax.getValue(), 0); | ||
| } | ||
| if (hasInternalMin) { | ||
| double expected = inputs.stream().mapToDouble(i -> { | ||
| InternalMin min = i.getAggregations().get("min"); | ||
| return min.getValue(); | ||
| }).min().getAsDouble(); | ||
| InternalMin reducedMin = reduced.getAggregations().get("min"); | ||
| assertEquals(expected, reducedMin.getValue(), 0); | ||
| } | ||
| extraAssertReduced(reduced, inputs); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
...rc/test/java/org/elasticsearch/search/aggregations/bucket/filter/InternalFilterTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.search.aggregations.bucket.filter; | ||
|
|
||
| import org.elasticsearch.common.io.stream.Writeable.Reader; | ||
| import org.elasticsearch.search.aggregations.InternalAggregations; | ||
| import org.elasticsearch.search.aggregations.bucket.InternalSingleBucketAggregationTestCase; | ||
| import org.elasticsearch.search.aggregations.pipeline.PipelineAggregator; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class InternalFilterTests extends InternalSingleBucketAggregationTestCase<InternalFilter> { | ||
| @Override | ||
| protected InternalFilter createTestInstance(String name, long docCount, InternalAggregations aggregations, | ||
| List<PipelineAggregator> pipelineAggregators, Map<String, Object> metaData) { | ||
| return new InternalFilter(name, docCount, aggregations, pipelineAggregators, metaData); | ||
| } | ||
|
|
||
| @Override | ||
| protected void extraAssertReduced(InternalFilter reduced, List<InternalFilter> inputs) { | ||
| // Nothing extra to assert | ||
| } | ||
|
|
||
| @Override | ||
| protected Reader<InternalFilter> instanceReader() { | ||
| return InternalFilter::new; | ||
| } | ||
| } |
47 changes: 47 additions & 0 deletions
47
...c/test/java/org/elasticsearch/search/aggregations/bucket/global/InternalGlogbalTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.search.aggregations.bucket.global; | ||
|
|
||
| import org.elasticsearch.common.io.stream.Writeable.Reader; | ||
| import org.elasticsearch.search.aggregations.InternalAggregations; | ||
| import org.elasticsearch.search.aggregations.bucket.InternalSingleBucketAggregationTestCase; | ||
| import org.elasticsearch.search.aggregations.pipeline.PipelineAggregator; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class InternalGlogbalTests extends InternalSingleBucketAggregationTestCase<InternalGlobal> { | ||
| @Override | ||
| protected InternalGlobal createTestInstance(String name, long docCount, InternalAggregations aggregations, | ||
| List<PipelineAggregator> pipelineAggregators, Map<String, Object> metaData) { | ||
| return new InternalGlobal(name, docCount, aggregations, pipelineAggregators, metaData); | ||
| } | ||
|
|
||
| @Override | ||
| protected void extraAssertReduced(InternalGlobal reduced, List<InternalGlobal> inputs) { | ||
| // Nothing extra to assert | ||
| } | ||
|
|
||
| @Override | ||
| protected Reader<InternalGlobal> instanceReader() { | ||
| return InternalGlobal::new; | ||
| } | ||
|
|
||
| } |
47 changes: 47 additions & 0 deletions
47
.../test/java/org/elasticsearch/search/aggregations/bucket/missing/InternalMissingTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.search.aggregations.bucket.missing; | ||
|
|
||
| import org.elasticsearch.common.io.stream.Writeable.Reader; | ||
| import org.elasticsearch.search.aggregations.InternalAggregations; | ||
| import org.elasticsearch.search.aggregations.bucket.InternalSingleBucketAggregationTestCase; | ||
| import org.elasticsearch.search.aggregations.pipeline.PipelineAggregator; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class InternalMissingTests extends InternalSingleBucketAggregationTestCase<InternalMissing> { | ||
| @Override | ||
| protected InternalMissing createTestInstance(String name, long docCount, InternalAggregations aggregations, | ||
| List<PipelineAggregator> pipelineAggregators, Map<String, Object> metaData) { | ||
| return new InternalMissing(name, docCount, aggregations, pipelineAggregators, metaData); | ||
| } | ||
|
|
||
| @Override | ||
| protected void extraAssertReduced(InternalMissing reduced, List<InternalMissing> inputs) { | ||
| // Nothing extra to assert | ||
| } | ||
|
|
||
| @Override | ||
| protected Reader<InternalMissing> instanceReader() { | ||
| return InternalMissing::new; | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is not enough, we should protect against overflow so 100 or 200 should be enough ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docCount is a a long so it's totally fine, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a funny story to tell you about labels sometime. Remind me the next time we see each other in person.