Tests: Add unit test for InternalChildren #23261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
review
>test
jpountz
approved these changes
Feb 20, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
LGTM, just one minor comment about random parameter generation.
| protected InternalChildren createTestInstance(String name, List<PipelineAggregator> pipelineAggregators, | ||
| Map<String, Object> metaData) { | ||
| // we shouldn't use the full long range here since we sum doc count on reduce, and don't want to overflow the long range there | ||
| long docCount = Math.abs(randomInt()); |
Contributor
There was a problem hiding this comment.
if randomInt() returns -2^31 then docCount will be negative (since the absolute value cannot be represented as an int in that case)
Member
Author
There was a problem hiding this comment.
Okay, will change that to a positive int then.
Member
Author
|
Merging this, CI seems stuck but local tests passed. |
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #22278