Add parsing method to bulk response #23234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `fromXContent()` parsing method to BulkResponse.
tlrx
force-pushed
the
add-parsing-method-to-bulk-response
branch
from
f9042ea to
a570fd3
Compare
tlrx
changed the title
Member
Author
|
This is ready to review. |
javanna
approved these changes
Feb 20, 2017
| XContentParser.Token token = parser.nextToken(); | ||
| ensureExpectedToken(XContentParser.Token.START_OBJECT, token, parser::getTokenLocation); | ||
|
|
||
| long took = 0; |
Member
There was a problem hiding this comment.
nit: shall we initialize it to -1?
Member
Author
There was a problem hiding this comment.
Yes, that would be aligned with ingest took millis.
| } else if (INGEST_TOOK.equals(currentFieldName)) { | ||
| ingestTook = parser.longValue(); | ||
| } else if (ERRORS.equals(currentFieldName) == false) { | ||
| throwUnknownField(currentFieldName, parser.getTokenLocation()); |
Member
There was a problem hiding this comment.
we don't parse errors as we don't have a field for it in the response?
Member
Author
There was a problem hiding this comment.
Yes, errors is the output of the BulkResponse.hasFailures() method which simply iterates over bulk item and checks for failed item.
Member
Author
|
Thanks @javanna ! |
tlrx
added a commit
that referenced
this pull request
Feb 21, 2017
This commit adds the `fromXContent()` parsing method to BulkResponse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
fromXContent()parsing method to BulkResponse.