Skip to content

Conversation

@bleskes
Copy link
Contributor

@bleskes bleskes commented Feb 8, 2017

After the first cluster state from a new master is processed, NodeConnectionService guarantees we connect to the new master. This removes the need to explicitly connect to the master in the MasterFaultDetection code making it simpler and bypasses the assertion triggered due to the blocking operation on the cluster state thread.

Relates to #22828

…en processed and the NodeConnectionService connect to the new master

This removes the need to explicitly connect to the master, which triggers an assertion due to the blocking operation on the cluster state thread.

Relates to elastic#22828
@bleskes bleskes added :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >enhancement v5.4.0 v6.0.0-alpha1 labels Feb 8, 2017
@bleskes bleskes requested a review from ywelsch February 8, 2017 06:32
Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleskes bleskes merged commit 0161eda into elastic:master Feb 8, 2017
@bleskes bleskes deleted the discovery_master_fd_on_processed branch February 8, 2017 11:49
@bleskes
Copy link
Contributor Author

bleskes commented Feb 8, 2017

thx @s1monw @ywelsch

bleskes added a commit that referenced this pull request Feb 9, 2017
…en processed and the NodeConnectionService connect to the new master (#23037)

After the first cluster state from a new master is processed, NodeConnectionService guarantees we connect to the new master. This removes the need to explicitly connect to the master in the MasterFaultDetection code making it simpler and bypasses the assertion triggered due to the blocking operation on the cluster state thread.

Relates to #22828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >enhancement v5.4.0 v6.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants