Skip to content

[TEST] Added unit tests for sum aggs. #22954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[TEST] Added unit tests for sum aggs. #22954

wants to merge 0 commits into from

Conversation

@martijnvg
Copy link
Member

@martijnvg martijnvg commented Feb 3, 2017

Relates to #22278

@martijnvg martijnvg added :Analytics/Aggregations Aggregations review >test Issues or PRs that are addressing/adding tests v5.3.0 v6.0.0-alpha1 labels Feb 3, 2017
@martijnvg martijnvg mentioned this pull request Feb 3, 2017
Closed
63 tasks
jpountz
jpountz approved these changes Feb 3, 2017
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/src/main/java/org/elasticsearch/search/aggregations/metrics/sum/SumAggregator.java Outdated
Copy link
Contributor

@jpountz jpountz Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@martijnvg martijnvg closed this Feb 6, 2017
@martijnvg martijnvg removed the v5.3.0 label Feb 6, 2017
@nik9000
Copy link
Member

nik9000 commented Feb 6, 2017

master: 9201ee8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

+1 more reviewer

@jpountz jpountz jpountz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvg @nik9000 @jpountz