Avoid losing ops in file-based recovery #22945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a primary is relocated from an old node to a new node, it can have ops in its translog that do not have a sequence number assigned. When a file-based recovery is started, this can lead to skipping these ops when replaying the translog due to a bug in the recovery logic. This commit addresses this bug and adds a test in the BWC tests.
bleskes
suggested changes
Feb 2, 2017
Contributor
bleskes
left a comment
bleskes
left a comment
There was a problem hiding this comment.
This LGTM. It would be great to have tests added in RecoverySourceHandlerTests .
| assertOK(response); | ||
| final InputStream content = response.getEntity().getContent(); | ||
| final int actualCount = | ||
| Integer.parseInt(XContentHelper.convertToMap(JsonXContent.jsonXContent, content, false).get("count").toString()); |
Contributor
There was a problem hiding this comment.
Any chance to use something like ObjectPath.evaluate(shard, "seq_no.local_checkpoint")?
|
|
||
| logger.info("allowing shards on all nodes"); | ||
| updateIndexSetting(index, Settings.builder().putNull("index.routing.allocation.include._name")); | ||
| ensureGreen(); |
Contributor
There was a problem hiding this comment.
shall we add assert counts here too?
Member
Author
jasontedor
force-pushed
the
file-based-lost-ops
branch
from
4a01087 to
bb8884a
Compare
Member
Author
|
Thanks @bleskes. I've pushed commits in response to your comments. |
Contributor
|
test this please |
1 similar comment
Contributor
|
test this please |
Member
Author
|
Thanks @bleskes. |
clintongormley
added
:Distributed Indexing/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a primary is relocated from an old node to a new node, it can have ops in its translog that do not have a sequence number assigned. When a file-based recovery is started, this can lead to skipping these ops when replaying the translog due to a bug in the recovery logic. This commit addresses this bug and adds a test in the BWC tests.
Relates #22484