Add parsing from xContent to ShardSearchFailure #22699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
:Search/Search
javanna
approved these changes
Jan 19, 2017
Member
There was a problem hiding this comment.
shall we rather use assertToXContentEquivalent ? I am always cautious on comparing json strings (keys ordering etc.) but maybe in this case it's ok
Member
Author
There was a problem hiding this comment.
I think in the toXContent tests that are more a way of checking the intended output is as expected (and more to show a simple, fixed example output in the tests), string comparrison is more intuitive and shouldn't break. We also do this in the other toXContent tests, so I will leave this also to stay consistent.
tlrx
approved these changes
Jan 20, 2017
Member
tlrx
left a comment
tlrx
left a comment
There was a problem hiding this comment.
I left a minor comment in tests, otherwise LGTM
Member
There was a problem hiding this comment.
Why not assertEquals(XContentParser.Token.START_OBJECT, parser.nextToken()); ?
In preparation for being able to parse SearchResponse from its rest representation, this adds fromXContent to ShardSearchFailure.
cbuescher
force-pushed
the
addParsing-ShardSearchFailure
branch
from
b5a143d to
fc6113b
Compare
cbuescher
added a commit
that referenced
this pull request
Jan 20, 2017
In preparation for being able to parse SearchResponse from its rest representation, this adds fromXContent to ShardSearchFailure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for being able to parse SearchResponse from its rest
representation, this adds fromXContent to ShardSearchFailure.