Simplify bulk request execution #22697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areek
approved these changes
Jan 23, 2017
Contributor
There was a problem hiding this comment.
we can remove the unused imports here (namely: ActionRequest, DocWriteRequest.OpType, ReplicationRequest, ShardId and RestStatus)
dakrone
force-pushed
the
backport-bulk-single-op-actions
branch
from
52d67e6 to
6b99aad
Compare
Member
Author
|
Thanks for taking a look @areek! |
This is a bespoke backport of elastic#20109 for 5.x: Currently, bulk item requests can be any ActionRequest, this PR restricts bulk item requests to DocumentRequest. This simplifies handling failures during bulk requests. Additionally, a new enum is added to DocumentRequest to represent the intended operation to be performed by a document request (create, index, update and delete), which was previously represented with a mix of strings and index request operation type. Now, index request operation type reuses the new enum to specify whether the request should create or index a document. Restricting bulk requests to DocumentRequest further simplifies execution of shard-level bulk operations to use the same failure handling for index, delete and update operations. This PR also fixes a bug which executed delete operations twice for replica copies while executing bulk requests. Relates to elastic#19105 and elastic#20109
dakrone
force-pushed
the
backport-bulk-single-op-actions
branch
from
6b99aad to
3dfa414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bespoke backport of #20109 for 5.x:
Currently, bulk item requests can be any ActionRequest, this PR restricts bulk
item requests to DocumentRequest. This simplifies handling failures during bulk
requests. Additionally, a new enum is added to DocumentRequest to represent the
intended operation to be performed by a document request (create, index, update
and delete), which was previously represented with a mix of strings and index
request operation type.
Now, index request operation type reuses the new enum to specify whether the
request should create or index a document. Restricting bulk requests to
DocumentRequest further simplifies execution of shard-level bulk operations to
use the same failure handling for index, delete and update operations. This PR
also fixes a bug which executed delete operations twice for replica copies while
executing bulk requests.
Relates to #19105 and #20109