Add fromxcontent methods to delete response #22680
Conversation
tlrx
left a comment
tlrx
left a comment
There was a problem hiding this comment.
This looks good, it's indeed very similar to IndexResponse/IndexResponseTests.
I'd like to merge #22586 before this go in, so that we can mutualize some code in the tests. There will be a light modification in the ConstructingObjectParser as well but nothing big.
There was a problem hiding this comment.
I'm about to change this in #22586 so that DeleteResponse/IndexResponse/UpdateResponse don't have to repeat all these checks. There will be a assertDocWriteResponse() method, and here we only have to check for UpdateResponse specific fields.
This commit adds the parsing fromXContent() methods to the IndexResponse class. It's a pale copy of what has been done in elastic#22229.
dadoonet
force-pushed
the
pr/delete-from-xcontent
branch
from
1453094 to
0315dcc
Compare
|
@tlrx updated based on new changes and your comments |
| // Print the parsed object out and test that the output is the same as the original output | ||
| BytesReference parsedDeleteResponseBytes = toXContent(parsedDeleteResponse, xContentType); | ||
| try (XContentParser parser = createParser(xContentType.xContent(), parsedDeleteResponseBytes)) { | ||
| assertDocWriteResponse(deleteResponse, parser.map()); |
There was a problem hiding this comment.
You still need to check the parsed value of the found field, right?
And optimize imports
|
@tlrx updated with your comments. |
|
Thank you Tanguy! |
This commit adds the parsing fromXContent() methods to the DeleteResponse class. The method is based on a ObjectParser because it is easier to use when parsing parent abstract classes like DocWriteResponse. It also changes the ReplicationResponse.ShardInfo so that it now implements ToXContentObject. This way, the ShardInfo.fromXContent() method can be used by the DeleteResponse's ObjectParser. Backport of elastic#22680 in 5.x branch
3 participants
This commit adds the parsing fromXContent() methods to the IndexResponse class.
It's a pale copy of what has been done in #22229.
There are a lot of code in common between IndexResponse and DeleteResponse including in tests.
Do we want to keep it as it is or avoid code duplication?