Remove InternalAggregation.Type #22511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer needed. It used to contain a lot of strings used by serialization but those have since been removed. Now it is just another thing to pass around that we don't really need.
Member
Author
nik9000
force-pushed
the
agg_remove_type
branch
from
075d2ed to
189ad88
Compare
Contributor
|
nice LGTM |
nik9000
added a commit
that referenced
this pull request
Jan 10, 2017
It is no longer needed. It used to contain a lot of strings used by serialization but those have since been removed. Now it is just another thing to pass around that we don't really need.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer needed. It used to contain a lot of strings
used by serialization but those have since been removed. Now
it is just another thing to pass around that we don't really
need.