Ensure shrunk indices carry over version information from its source #22469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when an index is shrunk the version information is not carried over from the source to the target index. This can cause major issues like mapping incompatibilities for instance if an index from a previous major version is shrunk. This commit ensures that all version information from the soruce index is preserved when a shrunk index is created. Closes elastic#22373
Contributor
|
Sweet, thanks @s1monw |
s1monw
added a commit
that referenced
this pull request
Jan 6, 2017
…22469) Today when an index is shrunk the version information is not carried over from the source to the target index. This can cause major issues like mapping incompatibilities for instance if an index from a previous major version is shrunk. This commit ensures that all version information from the soruce index is preserved when a shrunk index is created. Closes #22373
s1monw
added a commit
that referenced
this pull request
Jan 6, 2017
…22469) Today when an index is shrunk the version information is not carried over from the source to the target index. This can cause major issues like mapping incompatibilities for instance if an index from a previous major version is shrunk. This commit ensures that all version information from the soruce index is preserved when a shrunk index is created. Closes #22373
clintongormley
added
:Data Management/Indices APIs
s1monw
added a commit
that referenced
this pull request
Feb 21, 2017
…22469) Today when an index is shrunk the version information is not carried over from the source to the target index. This can cause major issues like mapping incompatibilities for instance if an index from a previous major version is shrunk. This commit ensures that all version information from the soruce index is preserved when a shrunk index is created. Closes #22373
Contributor
Author
|
this PR was not pushed to 5.2.0 and 5.2.1 it will be in 5.2.2 if we release this branch again. Sorry for the inconvenience. I simply missed the backport for some reason. Thanks @gmoskovicz for pointing this out to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when an index is shrunk the version information is not carried over
from the source to the target index. This can cause major issues like mapping
incompatibilities for instance if an index from a previous major version is shrunk.
This commit ensures that all version information from the soruce index is preserved
when a shrunk index is created.
Closes #22373