introduce KV Processor in Ingest Node #22272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
:Data Management/Ingest Node
martijnvg
approved these changes
Dec 20, 2016
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM. Left a small comment.
Member
There was a problem hiding this comment.
maybe wrap includeKeys in a Collections.unmodifiableList(...)?
Contributor
Author
There was a problem hiding this comment.
definitely, it crossed my mind when I first started typing and forgot about it towards the end. thanks!
Contributor
Author
There was a problem hiding this comment.
updated to include this
Now you can parse field values of the `key=value` variety and have `key` be inserted as a field name in an ingest document. Closes elastic#22222.
Contributor
Author
|
retest this please |
talevy
added a commit
that referenced
this pull request
Dec 20, 2016
Now you can parse field values of the `key=value` variety and have `key` be inserted as a field name in an ingest document. Closes #22222.
talevy
added a commit
that referenced
this pull request
Dec 27, 2016
- checks for index-out-of-bounds - added unit tests for failed `field_split` and `value_split` scenarios missed this test in #22272.
talevy
added a commit
that referenced
this pull request
Dec 27, 2016
- checks for index-out-of-bounds - added unit tests for failed `field_split` and `value_split` scenarios missed this test in #22272.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can parse field values of the
key=valuevariety and havekeybe inserted as a field name in an ingest document.Closes #22222.