Add fromXContent() methods for ReplicationResponse #22196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
approved these changes
Dec 16, 2016
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
left minors on testing, LGTM though
Member
There was a problem hiding this comment.
I called these methods test*ToAndFromXContent() as they effectively do one complete roundtrip: toXContent -> fromXContent -> toXContent
Member
There was a problem hiding this comment.
can you clarify in the method name the difference between this method and the one above? I they they both are random but this one may have failures while the other one can't?
Member
Author
There was a problem hiding this comment.
I changed the name to testShardInfoWithFailureToXContent and yes, in this case there are failures.
This commit adds the parsing fromXContent() methods to the ReplicationResponse.ShardInfo and ReplicationResponse.ShardInfo.Failure classes.
tlrx
force-pushed
the
add-fromxcontent-methods-to-ReplicationResponse
branch
from
c8441ab to
a24107b
Compare
tlrx
added a commit
that referenced
this pull request
Dec 20, 2016
This commit adds the parsing fromXContent() methods to the ReplicationResponse.ShardInfo and ReplicationResponse.ShardInfo.Failure classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the parsing methods
fromXContent()to theReplicationResponse.ShardInfoandReplicationResponse.ShardInfo.Failureclasses.Note that it requires some utility methods from #22082