Internal: Refactor SettingCommand into EnvironmentAwareCommand #22175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change renames and changes the behavior of SettingCommand to have its primary method take in a fully initialized Environment for elasticsearch instead of just a map of settings. All of the subclasses of SettingCommand already did this at some point, so this just removes duplication.
Member
|
The concept is right, there's a failing test that is clearly related to this PR but I trust that you'll address. Fire at will. |
Member
Author
|
Thanks @jasontedor. I fixed the failing test, and |
rjernst
added a commit
that referenced
this pull request
Jan 6, 2017
* Internal: Refactor SettingCommand into EnvironmentAwareCommand This change renames and changes the behavior of SettingCommand to have its primary method take in a fully initialized Environment for elasticsearch instead of just a map of settings. All of the subclasses of SettingCommand already did this at some point, so this just removes duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames and changes the behavior of SettingCommand to have
its primary method take in a fully initialized Environment for
elasticsearch instead of just a map of settings. All of the subclasses
of SettingCommand already did this at some point, so this just removes
duplication.