Start to centralize creation of XContentParser in tests #22096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts to centralize creation of the `XContentParser` in `protected final` methods on `ESTestCase`. The idea is to enable adding `NamedXContentRegistry` relatively easily by giving tests a single place they can override to define the `NamedXContentRegistry`. Since `NamedXContentRegistry` doesn't exist yet neither does the override point. This doesn't attempt to migrate all the tests to calling the new methods to build the parsers. I wanted to make this so we could review the concept and then I'll merge a followup to migrate the tests.
nik9000
added
review
>test
Member
Author
Member
Author
|
Thanks for reviewing @martijnvg! |
nik9000
added a commit
that referenced
this pull request
Dec 13, 2016
Starts to centralize creation of the `XContentParser` in `protected final` methods on `ESTestCase`. The idea is to enable adding `NamedXContentRegistry` relatively easily by giving tests a single place they can override to define the `NamedXContentRegistry`. Since `NamedXContentRegistry` doesn't exist yet neither does the override point. This doesn't attempt to migrate all the tests to calling the new methods to build the parsers. I wanted to make this so we could review the concept and then I'll merge a followup to migrate the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts to centralize creation of the
XContentParserinprotected finalmethods onESTestCase. The idea is to enableadding
NamedXContentRegistryrelatively easily by giving testsa single place they can override to define the
NamedXContentRegistry. SinceNamedXContentRegistrydoesn'texist yet neither does the override point.
This doesn't attempt to migrate all the tests to calling the
new methods to build the parsers. I wanted to make this so we
could review the concept and then I'll merge a followup to
migrate the tests.