Clarify global checkpoint recovery #21934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when starting a new engine, we read the global checkpoint from the translog only if we are opening an existing translog. This commit clarifies this situation by distinguishing the three cases of engine creation in the constructor leading to clearer code.
bleskes
approved these changes
Dec 2, 2016
Contributor
bleskes
left a comment
bleskes
left a comment
There was a problem hiding this comment.
LGTM. Thanks @jasontedor
| seqNoStats.getMaxSeqNo(), | ||
| seqNoStats.getLocalCheckpoint(), | ||
| seqNoStats.getGlobalCheckpoint()); | ||
| logger.trace( |
Contributor
There was a problem hiding this comment.
nit: seqNoStats has a toString - just use it and be safe?
| logger.trace("created new InternalEngine"); | ||
| } | ||
|
|
||
| private static SequenceNumbersService sequenceNumberService( |
Contributor
There was a problem hiding this comment.
this is what you get from the crazy syntax 👅
Member
Author
|
retest this please |
In the constructor for the internal engine, we log a trace statement showing the recovered max sequence number, local checkpoint, and global checkpoint. This commit simplifies this logging statement to just use the fact that SeqNoStats implements toString.
Member
Author
|
Thanks @bleskes. |
64 tasks
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when starting a new engine, we read the global checkpoint from the
translog only if we are opening an existing translog. This commit
clarifies this situation by distinguishing the three cases of engine
creation in the constructor leading to clearer code.
Relates #21254