Add unit test for TribeNodeClusterStateTaskExecutor #21856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes TribeNodeClusterStateTaskExecutor a static class for unit testing. TribeNodeClusterStateTaskExecutor is responsible for applying cluster state updates to the tribe node state whenever an underlying cluster state is updated (i.e. adding/removing indices, updating nodes and merging custom metadata). The unit tests ensure the tribe state is properly updating when underlying cluster state tasks are seen by the tribe node in batches or as a single update. relates elastic#21552
areek
added
:Tribe Node
>test
Member
|
@bleskes Is this PR worth forking and bringing up to date? |
Member
|
Closing as there has been no feedback, feel free to comment if this was closed erroneously. Also @areek is probably not interested in bringing it back up to date and merging it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes TribeNodeClusterStateTaskExecutor a static class
for unit testing. TribeNodeClusterStateTaskExecutor is responsible
for applying cluster state updates to the tribe node state whenever
an underlying cluster state is updated (i.e. adding/removing indices,
updating nodes and merging custom metadata). The unit tests ensure
the tribe state is properly updating when underlying cluster state
tasks are seen by the tribe node in batches or as a single update.
NOTE: still need to add tests for updating tribe state with index-level
settings (block index metadata, block index read/write, on conflict)
relates #21552