Deprecate timestamp and ttl on index requests.
#21826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`timestamp` and `ttl` already emit deprecation warnings when they are set in the mappings, but not when they are used in index requests. We should fix it so that users are not caught by surprise when we stop accepting these parameters. Relates elastic#21670
Member
|
LGTM |
clintongormley
added
the
:Search Foundations/Mapping
jpountz
added a commit
that referenced
this pull request
Nov 29, 2016
`timestamp` and `ttl` already emit deprecation warnings when they are set in the mappings, but not when they are used in index requests. We should fix it so that users are not caught by surprise when we stop accepting these parameters. Relates #21670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestampandttlalready emit deprecation warnings when they are set inthe mappings, but not when they are used in index requests. We should fix it so
that users are not caught by surprise when we stop accepting these parameters.
Relates #21670