Install a security manager on startup #21716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Elasticsearch starts, we go through some initialization before we install a security manager. Yet, the JVM makes internal policy decisions on the basis of whether or not a security manager is present. This commit installs a security manager immediately on startup so that the JVM always thinks a security manager is present when making such policy decisions.
jasontedor
added
:Core/Infra/Core
Member
Author
|
retest this please |
2 similar comments
Member
Author
|
retest this please |
Member
Author
|
retest this please |
Member
Author
|
This passes for me locally so even though the CI is struggling with what appear to transient issues I'm going to merge. |
jasontedor
added a commit
that referenced
this pull request
Nov 22, 2016
When Elasticsearch starts, we go through some initialization before we install a security manager. Yet, the JVM makes internal policy decisions on the basis of whether or not a security manager is present. This commit installs a security manager immediately on startup so that the JVM always thinks a security manager is present when making such policy decisions. Relates #21716
jasontedor
added a commit
that referenced
this pull request
Nov 22, 2016
When Elasticsearch starts, we go through some initialization before we install a security manager. Yet, the JVM makes internal policy decisions on the basis of whether or not a security manager is present. This commit installs a security manager immediately on startup so that the JVM always thinks a security manager is present when making such policy decisions. Relates #21716
jasontedor
added a commit
that referenced
this pull request
Nov 22, 2016
When Elasticsearch starts, we go through some initialization before we install a security manager. Yet, the JVM makes internal policy decisions on the basis of whether or not a security manager is present. This commit installs a security manager immediately on startup so that the JVM always thinks a security manager is present when making such policy decisions. Relates #21716
Member
Author
|
Thanks @rjernst. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Elasticsearch starts, we go through some initialization before we
install a security manager. Yet, the JVM makes internal policy decisions
on the basis of whether or not a security manager is present. This
commit installs a security manager immediately on startup so that the
JVM always thinks a security manager is present when making such policy
decisions.