Clarify that plugins can be closed #21669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
:Core/Infra/Plugins
Plugins are closed if they implement java.io.Closeable but this is not clear from the plugin interface. This commit clarifies this by declaring that Plugins implement java.io.Closeable and adding an empty implementation to the base Plugin class.
jasontedor
force-pushed
the
plugins-close
branch
from
2ed165a to
ced793c
Compare
jasontedor
added a commit
that referenced
this pull request
Nov 18, 2016
Plugins are closed if they implement java.io.Closeable but this is not clear from the plugin interface. This commit clarifies this by declaring that Plugins implement java.io.Closeable and adding an empty implementation to the base Plugin class. Relates #21669
Member
Author
|
Thanks @rjernst. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins are closed if they implement java.io.Closeable but this is not
clear from the plugin interface. This commit clarifies this by declaring
that Plugins implement java.io.Closeable and adding an empty
implementation to the base Plugin class.