Respect default search timeout #21599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
:Search/Search
The default search timeout is not respected because the timeout is unconditionally set from the query. This commit fixes this issue, and adds a test that the default search timeout is correctly attached to the search context.
jasontedor
force-pushed
the
search-timeout
branch
from
b6ba32c to
c782d55
Compare
Member
Author
|
This bug was introduced in 5.0.0. |
Member
|
LGTM |
jasontedor
added a commit
that referenced
this pull request
Nov 16, 2016
The default search timeout is not respected because the timeout is unconditionally set from the query. This commit fixes this issue, and adds a test that the default search timeout is correctly attached to the search context. Relates #21599
jasontedor
added a commit
that referenced
this pull request
Nov 16, 2016
The default search timeout is not respected because the timeout is unconditionally set from the query. This commit fixes this issue, and adds a test that the default search timeout is correctly attached to the search context. Relates #21599
Member
Author
|
Thanks @rjernst. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default search timeout is not respected because the timeout is
unconditionally set from the query. This commit fixes this issue, and
adds a test that the default search timeout is correctly attached to the
search context.
Closes #21595, relates #12211