Skip to content

Conversation

@yoonkh2000
Copy link

It’s not operate when %java_home% contains space.
like ‘C:\Program Files (x86)\Java\jre1.8.0_101’

related #20809

It’s not operate when %java_home% contains space.
like ‘C:\Program Files (x86)\Java\jre1.8.0_101’

related elastic#20809
@yoonkh2000
Copy link
Author

I signed the CLA now.

@jasontedor
Copy link
Member

jasontedor commented Nov 15, 2016

I'm not sure, can you please provide clear steps to reproduce? To be clear, in the Windows VM that I test on, the path to java contains a space.

@yoonkh2000
Copy link
Author

yoonkh2000 commented Nov 16, 2016

image
(error case - exist path containing 2 spaces without quotation mark)
('은(는) 예상되지 않았습니다' means 'was unexpected at this time.')

image
(error case - not exist path containing 2 spaces without quotation mark)

image
(not exist path containing 1 space without quotation mark)

image
(not exist path containing 2 spaces with quotation mark)

image
(exist path containing 2 spaces with quotation martk but java 1.7)

image
(exist path containing 1 space with quotation mark, java 1.8)

I tested several cases for confirmation.
It works when java_home path have 1 space. but error occurred when java_home path have 2 spaces.

@clintongormley clintongormley added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >bug labels Nov 19, 2016
@clintongormley clintongormley changed the title Fix java_home error in elasticsearch.in.bat on winodws On windows, allow java_home to contain spaces Nov 19, 2016
@jasontedor
Copy link
Member

Thank you for clarifying @yoonkh2000. I looked into this issue, and there is more work needed here. I would like to get a fix in quickly for the next release, so I'm going to open a separate PR and close this one. Thank you for opening this PR and leading the way on this issue.

@jasontedor
Copy link
Member

I opened #21921.

@yoonkh2000
Copy link
Author

Okay. Thanks @jasontedor

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts feedback_needed Team:Delivery Meta label for Delivery team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants